Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): support to configure token algorithm for antd 5 #11461

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

Wxh16144
Copy link
Member

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Jul 26, 2023 4:35pm

container = (
<ConfigProvider
theme={({
algorithm: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上面已经包了 ConfigProvider 了,改下 theme 列表应该就行了吧。

时机应该在用户修改之前,感觉要放到 getAntdConfig 里。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外我理解目前 appConfig 要强依赖 configProvider ,这个 configProvider 选项应该在 compact / dark / appConfig 时都自动打开。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前 appConfig 要强依赖 configProvider

貌似不是强依赖, AppConfig 只是帮助开发者将 message 这类弹窗的 contextHolder 节点放在上下文中, 不仅仅消费 CP 的 theme token 包括其他多语言可能都有...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以包两层 ConfigProvider 吗?当用户配置了 configProvider 的时候就有两层了。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我尝试看看能不能调整一下

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里如果是响应 theme 外的 darkcompact 的话,保证这里的 ConfigProvider 是在 theme 的 ConfigProvider 外面的就行,这样 themealgorithm 配置会覆盖 antd.compactantd.dark

对于 antd@5 来说 darkcompacttheme 的一部分,保证 theme 的优先级更高就可以

@afc163
Copy link
Contributor

afc163 commented Jul 27, 2023

cc @zombieJ

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript changed the title feat(antd-plugin): support for antd@5 token algorithm in configuration feat(plugins): support to configure token algorithm for antd 5 Aug 17, 2023
@PeachScript PeachScript merged commit 23adb52 into umijs:master Aug 17, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants