Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: compat with old hash anchors #12211

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Mar 17, 2024

close #12158

因为:

以上两个对文档 title 的改动,导致以前的 hash 锚点失效了,大面积历史 url 无法正常跳转。

由于大量历史锚点(特别是 patchClientRoutes 等)使用的十分频繁,所以影响面非常大,比较严重。

此 PR 兼容了历史锚点并跳转到新锚点。

注:若以后还需改动 title ,应考虑将跳转逻辑变为 map 映射,防止过多兼容逻辑反复运行的成本。

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 1:46am

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.41%. Comparing base (66b4809) to head (205dda0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12211      +/-   ##
==========================================
- Coverage   28.41%   28.41%   -0.01%     
==========================================
  Files         492      492              
  Lines       15155    15156       +1     
  Branches     3619     3620       +1     
==========================================
  Hits         4306     4306              
  Misses      10078    10078              
- Partials      771      772       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fz6m fz6m merged commit 8bfd4c7 into umijs:master Mar 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] 兼容被修改的文档锚点
1 participant