fix(preset-umi): wrong public path when preloading route chunks for qiankun app #12234
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
WalkthroughThe update modifies the way functions are passed to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts (1 hunks)
Additional comments: 1
packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts (1)
- 222-262: The change to the
addHTMLHeadScriptsmethod to accept an object with afnproperty instead of a direct function is a significant alteration. This approach enhances flexibility and allows for additional properties to be passed in the future if needed. However, ensure that all calls toaddHTMLHeadScriptsthroughout the codebase have been updated to match the new signature to avoid runtime errors.Additionally, setting the stage to
9999significantly increases the execution priority of the plugin's operations. While this ensures that the plugin's actions take precedence over others, it's crucial to document the rationale behind such a high priority value to aid future maintainability and understanding of the codebase.Consider adding comments explaining the choice of
9999for the stage value, including any potential impacts this might have on the execution order of other plugins or operations.
packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
Outdated
Show resolved
Hide resolved
…adOnLoad.ts Co-authored-by: Peach <scdzwyxst@gmail.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
PeachScript
changed the title
PeachScript
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12234 +/- ##
==========================================
- Coverage 28.41% 28.41% -0.01%
==========================================
Files 492 492
Lines 15166 15167 +1
Branches 3626 3626
==========================================
Hits 4310 4310
- Misses 10084 10085 +1
Partials 772 772 ☔ View full report in Codecov by Sentry. |
增加优先级 stage: 9999
Summary by CodeRabbit