Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support svg as component #1263

Merged
merged 1 commit into from
Oct 16, 2018
Merged

feat: support svg as component #1263

merged 1 commit into from
Oct 16, 2018

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Oct 16, 2018

e.g.

import { ReactComponent as Rice } from './rice.svg';

export default function() {
  return (
    <div>
      <h1>Page index</h1>
      <Rice width="120" height="120" />
    </div>
  );
}

例子

参考

@afc163
Copy link
Contributor

afc163 commented Oct 16, 2018

https://ant.design/components/icon/#Custom-SVG-Icon

能配合这个用么

@sorrycc sorrycc merged commit d9717c3 into master Oct 16, 2018
@sorrycc sorrycc deleted the feat/svg-component branch October 16, 2018 22:40
@sorrycc
Copy link
Member Author

sorrycc commented Oct 16, 2018

这个不已经是 react 组件了吗?

@shengbeiniao
Copy link

能否支持svg-sprite-loader

@2b0x
Copy link

2b0x commented May 8, 2023

诚哥你好呀请教一下 关于将svg作为组件引入使用遇到的小问题。
一开始我是用antd3的 @svgr/webpack 的这个loader 结果就是引入svg时,开发环境把svg当成依赖了,然后警告找不到相关依赖

后面看到你这个pr,于是尝试了下,开发环境是没任何问题的,但是在构建机上构建的时候,总是构建不通过,经过排查,就是ReactComponent导致的。
请问这个构建时,是否和node版本有关系,我本地是node16~ 看构建机的错误日志,没啥头绪~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants