Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(umi-test): merge moduleNameMapper from jest.config.js #1322

Merged
merged 2 commits into from
Oct 25, 2018
Merged

feat(umi-test): merge moduleNameMapper from jest.config.js #1322

merged 2 commits into from
Oct 25, 2018

Conversation

mutouzdl
Copy link
Contributor

@mutouzdl mutouzdl commented Oct 25, 2018

jest.config.js的moduleNameMapper改为合并的方式进行配置,避免覆盖默认配置。

Close #1320

jest.config.js的moduleNameMapper改为合并的方式进行配置,避免覆盖默认配置。
@coveralls
Copy link

coveralls commented Oct 25, 2018

Pull Request Test Coverage Report for Build 1763

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 23 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.008%) to 34.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-test/src/index.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi/src/renderRoutes.js 1 96.97%
packages/umi-test/src/index.js 1 0.0%
packages/umi-build-dev/src/FilesGenerator.js 21 0.93%
Totals Coverage Status
Change from base Build 1757: -0.008%
Covered Lines: 1038
Relevant Lines: 3059

💛 - Coveralls

@@ -33,13 +35,14 @@ export default function(opts = {}) {
moduleNameMapper: {
'\\.(css|less|sass|scss)$': require.resolve('identity-obj-proxy'),
...(moduleNameMapper || {}),
...userModuleNameMapper,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要做个为空判断吧。

@sorrycc sorrycc changed the title fixed #1320 feat: merge moduleNameMapper from jest.config.js Oct 25, 2018
@sorrycc sorrycc changed the title feat: merge moduleNameMapper from jest.config.js feat(umi-test): merge moduleNameMapper from jest.config.js Oct 25, 2018
userModuleNameMapper增加空值判断。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants