Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dynamicImport.loadingComponent as stateless function str #1325

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Oct 25, 2018

e.g.

export default {
  plugins: [
    ['umi-plugin-react', {
      dynamicImport: {
        loadingComponent: `() => <div>...</div>`,
      },
    }],
  ],
}

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1768

  • 1 of 5 (20.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 33.274%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-plugin-react/src/plugins/dynamicImport.js 0 4 0.0%
Totals Coverage Status
Change from base Build 1766: -0.02%
Covered Lines: 1054
Relevant Lines: 3249

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants