fix: LocaleProvider warning after antd@3.21 #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenshuai2144
approved these changes
Aug 6, 2019
Pull Request Test Coverage Report for Build 4993
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5147
💛 - Coveralls |
|
这对 antd 的版本有要求吧？ |
|
@sorrycc 嗯，看 umi-plugin-react 里写的是 |
|
什么版本开始的？umi-plugin-react 会优先用项目里依赖的 antd 版本，如果用户手写了低版本 antd，会有 break-change 。 |
|
需要判断下 antd version @chenshuai2144 mac 机器重启下，一直卡住 |
hstarorg
reviewed
Aug 7, 2019
| {ret} | ||
| </LocaleProvider>); | ||
| </ConfigProvider>); | ||
| {{/antd}} | ||
| return ret; |
ycjcl868
reviewed
Aug 9, 2019
| @@ -122,9 +122,9 @@ class LocaleWrapper extends React.Component{ | |||
| </IntlProvider>) | |||
| {{/localeList.length}} | |||
| {{#antd}} | |||
| return (<LocaleProvider locale={appLocale.antd ? (appLocale.antd.default || appLocale.antd) : defaultAntd}> | |||
| return (<ConfigProvider locale={appLocale.antd ? (appLocale.antd.default || appLocale.antd) : defaultAntd}> | |||
There was a problem hiding this comment.
import { version, LocaleProvider, ConfigProvider } from 'antd';
const AntdProvider = Number(major) > 3 || Number(major) >= 3 && Number(minor) >= 21 ? ConfigProvider : LocaleProvider;
<AntdProvider ...
ycjcl868
force-pushed
the
zombieJ-patch-1
branch
from
c5246d0
to
e5af6ac
Compare
* fix: judge antd version * fix: format * fix: ci
sorrycc
changed the title
|
实现有些问题，在 #2992 回滚，后面提新的 PR 再处理。 |
sorrycc
added a commit
that referenced
this pull request
Aug 14, 2019
|
请问这个问题好了吗，已有的项目改如何操作才能去掉这个警告啊 |
|
@ycjcl868 您好，我看到umi的发布日志上解决了有说解决了这个问题，但是我不知道我该如何操作。。是要更新什么呢？ |
|
@zhipingzhang 还没，今天更新个版本修复，不需要操作什么，重装依赖就好。 |
您好，我刚刚试了下删掉node_modules，用npm-check-updates更新package.json全部依赖到最新版本，然后yarn安装，发现还是存在这些报错呀
|
似乎现在重装依赖还是有这个问题。。 |
|
|
提示没有了，但是默认弹窗不显示中文，有遇到的吗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesClose #2962 #2966 ant-design/ant-design-pro#5014
Description of change