Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(umi): add mergeAsyncConfig api to support async runtime config #3027

Merged
merged 1 commit into from Aug 22, 2019
Merged

feat(umi): add mergeAsyncConfig api to support async runtime config #3027

merged 1 commit into from Aug 22, 2019

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Aug 20, 2019

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@kuitos kuitos requested a review from sorrycc August 20, 2019 08:55
This was referenced Aug 20, 2019
Merged
Merged
@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited

Pull Request Test Coverage Report for Build 5373

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 33.906%
Totals Coverage Status
Change from base Build 5339: 0.1%
Covered Lines: 1496
Relevant Lines: 4418
💛 - Coveralls

@sorrycc
Copy link
Member

sorrycc commented Aug 21, 2019

改个名，按其他接口的约定，应该是 mergeAsyncConfig -> mergeConfigAsync。

@kuitos
Copy link
Member Author

kuitos commented Aug 21, 2019

done @sorrycc

@sorrycc sorrycc merged commit 1e78bdb into umijs:master Aug 22, 2019
@kuitos kuitos deleted the kuitos-master branch August 22, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorrycc sorrycc Awaiting requested review from sorrycc

Assignees
No one assigned
Labels
pr(enhancement)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuitos @coveralls @sorrycc