node_modules下的tsx也运行转义 #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 222
💛 - Coveralls |
added 2 commits
April 21, 2018 00:59
sorrycc
requested changes
Apr 23, 2018
| @@ -68,9 +68,6 @@ export default function dev({ | |||
| 'access-control-allow-origin': '*', | |||
| }, | |||
| publicPath: webpackConfig.output.publicPath, | |||
| watchOptions: { | |||
| @@ -424,14 +424,13 @@ export default function getConfig(opts = {}) { | |||
| }, | |||
| { | |||
| test: /\.(js|jsx)$/, | |||
| include: opts.cwd, | |||
| include: [opts.cwd,/packages/], | |||
There was a problem hiding this comment.
默认不要加，有可能会误伤。通过环境变量开启吧，比如 LERNA=true 时才加上 /packages/ 的 include。
There was a problem hiding this comment.
想了想，这个通过 extraBabelIncludes 配就好，不要加这个逻辑了。
There was a problem hiding this comment.
tsx 下面不是删了 node_modules 的 exclude 条件了吗？
There was a problem hiding this comment.
我的意思是想让tsx 也应该有watch 功能，但是watch 因为性能问题忽略掉“node_modules”，我想是不是应该跟 babel 一样，也用白名单机制， 如果不能共用extraBabelIncludes配置，只能新增配置extraTsxIncludes 这样是否可行？
|
https://webpack.js.org/configuration/watch/#watchoptions-ignored |
|
@sorrycc 那就通过白名单的方式 添加watch 文件，其实主要是在lerna 上用 |
|
写个最简单的 lerna 例子，贴出来，我跑跑看？ |
|
@sorrycc 稍等 |
|
@sorrycc 重新修改测试了下，针对tsx , 发现只要注释代码： |
sorrycc
pushed a commit
that referenced
this pull request
Jun 23, 2022
* ci: upgrade cache version * ci: use pnpm action setup
xierenyuan
pushed a commit
to xierenyuan/umi
that referenced
this pull request
Jun 23, 2022
* ci: upgrade cache version * ci: use pnpm action setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
取消node_modules排除，让 tsx 也跟less一样，可以在第三方库里面载入