Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setConfig uppercase strings #3868

Merged
merged 1 commit into from Jan 4, 2020
Merged

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Jan 4, 2020

Close #3866.

image

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@netlify
Copy link

netlify bot commented Jan 4, 2020

Ant Design Pro preview using the current branch umi

Built with commit 07bed45

https://deploy-preview-3868--pro-pre-umijs.netlify.com

@ycjcl868
Copy link
Contributor Author

ycjcl868 commented Jan 4, 2020

/rebase

@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #3868 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3868   +/-   ##
=======================================
  Coverage   40.54%   40.54%           
=======================================
  Files         283      283           
  Lines        8010     8010           
  Branches     1886     1937   +51     
=======================================
  Hits         3248     3248           
+ Misses       4388     4381    -7     
- Partials      374      381    +7
Impacted Files Coverage Δ
...build-dev/src/plugins/commands/config/setConfig.js 100% <100%> (ø) ⬆️
...kages/umi-plugin-ui/src/plugins/dashboard/index.ts 0% <0%> (ø) ⬆️
...s/umi-build-dev/src/plugins/commands/block/util.ts 33.11% <0%> (ø) ⬆️
packages/umi-plugin-ui/src/bubble/index.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a194a6...07bed45. Read the comment docs.

@ycjcl868 ycjcl868 merged commit 413d260 into master Jan 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-setConfig-uppercase branch January 4, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setConfig 写入大写字母报错
1 participant