fix: service.resolvePackage not working properly while APP_ROOT specified #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ant Design Pro preview using the current branch umi Built with commit fd4313b |
Codecov Report
@@ Coverage Diff @@
## master #4044 +/- ##
=========================================
+ Coverage 83.87% 83.9% +0.02%
=========================================
Files 127 128 +1
Lines 2524 2528 +4
Branches 635 631 -4
=========================================
+ Hits 2117 2121 +4
- Misses 398 399 +1
+ Partials 9 8 -1
Continue to review full report at Codecov.
|
sorrycc
requested changes
Mar 3, 2020
那service里的 |
是的。 |
sorrycc
reviewed
Mar 3, 2020
| @@ -9,6 +11,7 @@ const args = yParser(process.argv.slice(2)); | |||
| process.env.NODE_ENV = 'development'; | |||
| const service = new Service({ | |||
| cwd: getCwd(), | |||
| pkg: getPkg(process.cwd()), | |||
There was a problem hiding this comment.
不对，有 APP_ROOT 的时候，是不是也应该先找 APP_ROOT 下的 package.json，再找根节点的？
This was referenced Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
While env
APP_ROOTis specified,service.resolvePackageI()returns info incorrectly.Check my repo: hosts-master
@umijs/plugin-modelwill not be discovered properly