feat: add eventbus and dynamic import page init event, ref #38. #41

zhang740 · 2018-01-03T07:20:02Z

No description provided.

sorrycc · 2018-01-03T09:12:04Z

packages/umi-build-dev/src/getRouterContent.js

        routeConfig[key],
-      )}' */'${pageJSFile}')${loadingOpts})}></Route>`;
+      )}' */'${pageJSFile}'), { callback: (err) => callback('${key}', err), ${loadingOpts} }) }></Route>`;


逗号应该在 loadingOpts 里。

feat: add eventbus and dynamic import page init event.

1db3333

zhang740 requested a review from sorrycc January 3, 2018 07:20

sorrycc reviewed Jan 3, 2018

View reviewed changes

sorrycc merged commit 537e77c into master Jan 3, 2018

sorrycc deleted the feat-event branch January 3, 2018 09:14

sorrycc mentioned this pull request Jan 4, 2018

Emit a global event when Page Component is initialized #38

Closed

xierenyuan pushed a commit to xierenyuan/umi that referenced this pull request Jun 23, 2022

fix: production build not compress css (umijs#41)

3dca68b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add eventbus and dynamic import page init event, ref #38. #41

feat: add eventbus and dynamic import page init event, ref #38. #41

zhang740 commented Jan 3, 2018

sorrycc Jan 3, 2018

feat: add eventbus and dynamic import page init event, ref #38. #41

feat: add eventbus and dynamic import page init event, ref #38. #41

Conversation

zhang740 commented Jan 3, 2018

sorrycc Jan 3, 2018

Choose a reason for hiding this comment