Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add props.routes for route components #4842

Merged
merged 2 commits into from Jun 5, 2020
Merged

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Jun 5, 2020

```

考虑到预渲染后,大部分不会再用到 `umi.server.js` 服务端文件,构建完成后会删掉 `umi.server.js` 文件如果有调试、不删除 server 文件需求,可通过环境变量 `RM_SERVER_FILE=none` 来保留。
了解更多,可点击 [服务端渲染文档](/zh-CN/docs/ssr)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行没移上去

@ycjcl868
Copy link
Contributor

ycjcl868 commented Jun 5, 2020

需要 merge 下 master?

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #4842 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4842   +/-   ##
=======================================
  Coverage   82.73%   82.74%           
=======================================
  Files         151      151           
  Lines        3331     3332    +1     
  Branches      873      862   -11     
=======================================
+ Hits         2756     2757    +1     
- Misses        568      569    +1     
+ Partials        7        6    -1     
Impacted Files Coverage Δ
...s/renderer-react/src/renderRoutes/renderRoutes.tsx 96.66% <100.00%> (+0.05%) ⬆️
packages/core/src/Config/Config.ts 61.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc7aa7...2dcccd2. Read the comment docs.

@sorrycc
Copy link
Member Author

sorrycc commented Jun 5, 2020

需要 merge 下 master?

image

在 master co 出来的,应该不是这个问题,config 的文档我是执行了 sync from zh-ch 同步过来的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants