Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ci broken #6236

Merged
merged 2 commits into from
Mar 9, 2021
Merged

chore: ci broken #6236

merged 2 commits into from
Mar 9, 2021

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Mar 9, 2021 •
edited

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@ycjcl868 ycjcl868 requested a review from sorrycc March 9, 2021 09:50
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #6236 (5ab8c01) into master (b21cb6d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6236   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files         154      154           
  Lines        3507     3507           
  Branches      952      952           
=======================================
  Hits         2962     2962           
  Misses        535      535           
  Partials       10       10
Impacted Files Coverage Δ
packages/bundler-webpack/src/index.ts 36.06% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7304f6c...5ab8c01. Read the comment docs.

@ycjcl868 ycjcl868 merged commit 5ad7c7c into master Mar 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the chore-ci-broken-t branch March 9, 2021 10:09
sorrycc
sorrycc reviewed Mar 9, 2021
View reviewed changes
packages/bundler-webpack/src/DevCompileDonePlugin.ts
@@ -11,7 +11,7 @@ export default class DevCompileDonePlugin {
}
apply(compiler: webpack.Compiler) {
let isFirstCompile = true;
compiler.hooks.done.tap('DevFirstCompileDone', (stats) => {
compiler.hooks.done.tap('DevFirstCompileDone', (stats: any) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个应该看具体原因，而不是直接设 any，beta.7 时还是好的。

image

@sorrycc sorrycc mentioned this pull request Mar 10, 2021
Merged
4 tasks
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorrycc sorrycc sorrycc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ycjcl868 @sorrycc