Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(preset-built-in): Condition 'windowInitialVars' is always true #6408

Merged
merged 1 commit into from
Apr 13, 2021
Merged

style(preset-built-in): Condition 'windowInitialVars' is always true #6408

merged 1 commit into from
Apr 13, 2021

Conversation

xjh22222228
Copy link
Contributor

Condition 'windowInitialVars' is always true, remove {}

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #6408 (efb8ffa) into master (0bb4290) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6408   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files         157      157           
  Lines        3564     3564           
  Branches      975      974    -1     
=======================================
  Hits         3020     3020           
  Misses        534      534           
  Partials       10       10           
Impacted Files Coverage Δ
...ilt-in/src/plugins/features/ssr/templates/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb4290...efb8ffa. Read the comment docs.

@ycjcl868
Copy link
Contributor

Object.keys(var || {}) 保守写法,避免 var undefined 造成 error
image

@xjh22222228
Copy link
Contributor Author

xjh22222228 commented Apr 13, 2021

Object.keys(var || {}) 保守写法,避免 var undefined 造成 error
image

不对呀, windowInitialVars 始终是对象,怎么会为 undefined, 而且是个常量。

@ycjcl868 ycjcl868 merged commit 48c2a15 into umijs:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants