New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config extraBabelIncludes is absolute, nodeModules all transform #6632
Merged
sorrycc
merged 10 commits into
master
from
fix-config-extraBabelIncludes-is-absolute-nodeModules-all-transform
May 26, 2021
Merged
fix: config extraBabelIncludes is absolute, nodeModules all transform #6632
sorrycc
merged 10 commits into
master
from
fix-config-extraBabelIncludes-is-absolute-nodeModules-all-transform
May 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6632 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 157 157
Lines 3599 3599
Branches 991 991
=======================================
Hits 3051 3051
Misses 538 538
Partials 10 10
Continue to review full report at Codecov.
|
ycjcl868
reviewed
May 25, 2021
circleci 里的用例为啥挂了? |
delete-merged-branch
bot
deleted the
fix-config-extraBabelIncludes-is-absolute-nodeModules-all-transform
branch
May 26, 2021 02:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复当 extraBabelIncludes 配置的是绝对路径的时候,会自动编译所有的模块。
感觉应该是逻辑bug
举例子:
目录结构如下:
因为我没有配置了 footer,因此引用 footer 的文件应该报错才对,但是此时却全都正确运行了。
Checklist
npm test
passesDescription of change