New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve route #721

Merged

sorrycc merged 4 commits into master from improve-route-fetch

Jul 23, 2018

Member

sorrycc commented Jul 23, 2018 •

edited

Loading

TODO:

支持从 route component 里读 yaml config 注释来扩展路由的能力
权限路由支持数组
删除 page.js 的支持


          feat: support getYamlConfig from route component

57985be

sorrycc added the type(enhancement) label

coveralls commented Jul 23, 2018

Pull Request Test Coverage Report for Build 891

8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 27.27%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/umi-build-dev/src/routes/getYamlConfig.js	8	10	80.0%

Totals
Change from base Build 889:	0.1%
Covered Lines:	651
Relevant Lines:	2487

💛 - Coveralls

coveralls commented Jul 23, 2018 •

edited

Loading

Pull Request Test Coverage Report for Build 897

25 of 42 (59.52%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 27.119%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/umi-build-dev/src/routes/getYamlConfig.js	8	10	80.0%
packages/umi/src/renderRoutes.js	0	15	0.0%

Totals
Change from base Build 889:	-0.02%
Covered Lines:	652
Relevant Lines:	2502

💛 - Coveralls

sorrycc added 3 commits

July 23, 2018 14:37


          feat: support config route in route component

d160574


          more testcase

a7077ae


          feat: support auth Routes in Array

bc1937b

sorrycc merged commit 2622427 into master

sorrycc deleted the improve-route-fetch branch

July 23, 2018 09:35

Contributor

xiaoxiangmoe commented Aug 6, 2018

求相关文档……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment