-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 🎨 base config valiate endsWith('/') #9776
Conversation
stormslowly
commented
Nov 15, 2022
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
3ea1e8b
to
10d8f22
Compare
Size Change: +39 B (0%) Total Size: 9.97 MB
ℹ️ View Unchanged
|
Codecov ReportBase: 28.45% // Head: 28.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #9776 +/- ##
=======================================
Coverage 28.45% 28.45%
=======================================
Files 427 427
Lines 12070 12070
Branches 2884 2884
=======================================
Hits 3434 3434
Misses 8079 8079
Partials 557 557
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -4,7 +4,8 @@ import type { Root } from '@umijs/utils/compiled/@hapi/joi'; | |||
|
|||
export function getSchemas(): Record<string, (Joi: Root) => any> { | |||
return { | |||
base: (Joi) => Joi.string(), | |||
base: (Joi) => | |||
Joi.string().label('base').pattern(/\/$/, { name: `"endsWith '/'"` }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
错误提示是不是太少了,有人看不懂,加个 chalk 颜色会不会更好 😢
This reverts commit 86bcacd.