Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] option to list residential teleports instead or in addition to travel shortcuts #7

Closed
LTS-FFXIV opened this issue Apr 20, 2024 · 7 comments
Labels
feature New feature or request

Comments

@LTS-FFXIV
Copy link
Contributor

This list
image

Showing these teleports instead, or in addition to (also if residential teleports could be renamed that'd be sick)
image

@haroldiedema haroldiedema added the feature New feature or request label Apr 20, 2024
@haroldiedema
Copy link
Contributor

haroldiedema commented Apr 20, 2024

I've tried to implement this, but managed to only get it working for an apartment and not an FC house. I need to spend some more time with this after the DTR bar implementation.

If you're comfortable with the code, you can find the relevant code here: https://github.com/una-xiv/umbra/blob/main/Umbra.Game/src/MainMenu/MainMenuRepository.cs#L112

I thought it would be just as simple as checking if aetheryte.IsSharedHouse and aetheryte.IsAppartment, but that doesn't seem to work for all cases from what I could test locally. Feel free to try this for yourself to see if you have more luck.

That said, I rather have a fully working estate list instead of just apartments. People will complain if they see only some of the residential options there instead of all of them.

@LTS-FFXIV
Copy link
Contributor Author

May want to look into how teleporterplugin populates residential teleports and allows for stuff like /tp home
https://github.com/pohky/TeleporterPlugin/blob/master/TeleporterPlugin/Managers/AetheryteManager.cs

@haroldiedema
Copy link
Contributor

haroldiedema commented Apr 22, 2024

I've added residential areas to the travel menu in bf9dcc3

image

You'll need to enable the option in Toolbar Settings:

image

Would you mind testing this? I don't have access to shared/private estates on my account 😅

@LTS-FFXIV
Copy link
Contributor Author

image

Only one of the shared estates is appearing
The private estate is ???
Apartment is not appearing

@haroldiedema
Copy link
Contributor

haroldiedema commented Apr 22, 2024

Can we discuss this on Discord? My id is liscion, or find me as Una in the dalamud discord. May speed things up a bit, since I can't really test this locally without spending millions of gil and waiting for lottery periods 😅

@haroldiedema
Copy link
Contributor

I've pushed an update that hopefully fixes it.

@haroldiedema
Copy link
Contributor

Fixed by #8

Thanks for the help! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants