Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add All Filters to Test Page #96

Closed
una opened this issue Nov 13, 2015 · 7 comments
Closed

Add All Filters to Test Page #96

una opened this issue Nov 13, 2015 · 7 comments

Comments

@una
Copy link
Owner

una commented Nov 13, 2015

The test page is missing a few filters. Let's document which ones exist and which ones are in need of getting added.

@m1
Copy link
Contributor

m1 commented Nov 15, 2015

Which filters do you know of that are missing? Will try and get them up but I'm pretty sure I did all the filters that were on the version of instagram (android emulator) I was using.

@una
Copy link
Owner Author

una commented Nov 15, 2015

ooh! There are likely more in the iOS version. Check out the README for the full list (i.e. Moon and Clarendon)

@m1
Copy link
Contributor

m1 commented Nov 17, 2015

Okay I found the issue, for some reason in the android emulator some filters are toggled off so a big update of the test page will come soon with around 15 more filters.

@m1
Copy link
Contributor

m1 commented Nov 17, 2015

Also since the new filters add ~75 new images, plus this with the current filters it's around 195 images on a single page -- maybe we should think about having a test page for each filter (this could be done programmatically via gulp) or having a accordion à la the one in bootstrap. What do you think @una ?

@una
Copy link
Owner Author

una commented Nov 17, 2015

@m1 Good point -- we could have a single page w/a left-side menu that will AJAX the test images in upon request? That would only need a single page still, and we can use HTML push-state for linking

@m1
Copy link
Contributor

m1 commented Nov 17, 2015

Sounds brill, I'll do the new filters first then get on with the new test stuff and clear up #109 in the process.

@una
Copy link
Owner Author

una commented Nov 17, 2015

Rockstar 🎸

@una una closed this as completed Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants