Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with Torch 1.2 #38

Closed
soares-f opened this issue Aug 26, 2019 · 1 comment · Fixed by #39
Closed

Incompatibility with Torch 1.2 #38

soares-f opened this issue Aug 26, 2019 · 1 comment · Fixed by #39
Assignees
@kepler
Labels
bug Something isn't working

Comments

@soares-f
Copy link

soares-f commented Aug 26, 2019 •
edited
Loading

Describe the bug
The following error is occurring when using openkiwi with PyTorch 1.2:

"Expected object of scalar type Byte but got scalar type Bool for argument #3 'other' "

The error happened for inference.

The same error does not occur with PyTorch 1.0.1

Environment (please complete the following information):

  • OS: Amazon Linux
  • OpenKiwi version: 0.1.1
  • Python version 3.6
@soares-f soares-f added the bug Something isn't working label Aug 26, 2019
@captainvera
Copy link
Contributor

Hey @soares-f

Thanks for bringing this to our attention! We will push a fix ASAP

@kepler kepler self-assigned this Aug 26, 2019
kepler added a commit that referenced this issue Aug 26, 2019
@kepler
Fix compatibility with PyTorch 1.2
32c4014 
Fixes #38.
@kepler kepler mentioned this issue Aug 26, 2019
Merged
captainvera pushed a commit that referenced this issue Aug 26, 2019
@kepler @captainvera
Fix compatibility with PyTorch 1.2 (#39)
6066f05 
Fixes #38 and add support for PyTorch 1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kepler kepler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility with PyTorch 1.2 Unbabel/OpenKiwi
3 participants
@kepler @captainvera @soares-f