Improper header checks in http plugin

[funkybob]

http.c:191: else if (uhttp.auto_gzip && !uwsgi_strnicmp("ACCEPT-ENCODING", 15, hh, keylen)) {
http.c:302: else if (uhttp.auto_gzip && !uwsgi_strncmp("ACCEPT_ENCODING", 15, hh, keylen)) {

At least one of these is wrong.

One calls strnicmp, the other strncmp.

One has _ the other has -

I wonder if this is related to why I can never get http-auto-gzip to work.

[unbit]

The right one is the 191 (we are managing the true header in case insensitive way, so the dash is the right char). Waiting for your pull request :)

[funkybob]

Some clarity is needed on how headers are checked:

            else if (!uwsgi_strnicmp("SEC-WEBSOCKET-VERSION", 21, hh, keylen)) {
            else if (!uwsgi_strnicmp("SEC-WEBSOCKET-KEY", 17, hh, keylen)) {
    if (!uwsgi_strnicmp("CONTENT-LENGTH", 14, hh, keylen)) {
    else if (!uwsgi_strnicmp("TRANSFER_ENCODING", 17, hh, keylen)) {
    else if (uhttp.auto_gzip && !uwsgi_strnicmp("ACCEPT-ENCODING", 15, hh, keylen)) {
if (uwsgi_strncmp("CONTENT_LENGTH", 14, hh, *keylen) && uwsgi_strncmp("CONTENT_TYPE", 12, hh, *keylen)) {

Can we assume that:

1. incoming headers are CGIified - that is, upper cased and '-' changed to '_'
2. outbound headers are all caps, and .... how are '-' and '_' handled?

If these are true, we can dispense with the case-insensitive compare [small speed up, maybe]