Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max-worker-lifetime-delta that works like max-requests-delta #2020

Closed
ergo opened this issue May 15, 2019 · 3 comments
Closed

Add max-worker-lifetime-delta that works like max-requests-delta #2020

ergo opened this issue May 15, 2019 · 3 comments

Comments

@ergo
Copy link
Contributor

ergo commented May 15, 2019

Hello,

We have an application that has quite a bit loading time, when max-worker-lifetime hits we get a bit of downtime. It would be great to have max-worker-lifetime-delta introduced that remedies the problem same way as max-requests-delta did.
@ergo ergo mentioned this issue May 15, 2019
Closed
@ergo
Copy link
Contributor Author

ergo commented May 23, 2019

Hi, any news on review/inclusion of the patch?

@ergo
Copy link
Contributor Author

ergo commented Aug 5, 2019

Hello, any news on this patch?

@bwesen
Copy link

bwesen commented Jan 26, 2020

This would be awesome to have. max-worker-lifetime is not good by itself as all the worker processes restart at roughly the same time, causing a huge spike in API latency.

@xrmx xrmx closed this as completed in 95d1d74 Jun 14, 2020
xrmx pushed a commit that referenced this issue Jun 14, 2020
@ergo @xrmx
core: add max-worker-lifetime-delta
e4b99e7 
To not reload workers at the same time, instead with a timeout that depends on
their worker id.

Fix #2020
ProgHaj added a commit to ProgHaj/uwsgi-docs that referenced this issue Sep 23, 2021
@ProgHaj
Add max-worker-lifetime-delta to docs
306fdbe 
I found max-worker-lifetime-delta had been added, but found no trace of it in the Options.rst

* https://github.com/unbit/uwsgi/pull/2021/files
* unbit/uwsgi#2020
* https://github.com/unbit/uwsgi/blob/master/core/master_checks.c
* https://github.com/unbit/uwsgi/blob/master/core/uwsgi.c
@ProgHaj ProgHaj mentioned this issue Sep 23, 2021
Open
@MarcThe MarcThe mentioned this issue Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add max-worker-lifetime-delta that works like max-requests-delta ergo/uwsgi
2 participants
@ergo @bwesen