Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Currency codes should precede amounts #228

Open
1 of 5 tasks
getsnoopy opened this issue Jul 16, 2021 · 1 comment
Open
1 of 5 tasks

Currency codes should precede amounts #228

getsnoopy opened this issue Jul 16, 2021 · 1 comment

Comments

@getsnoopy
Copy link

I'm submitting a…

  • Regression (a behaviour that used to work and stopped working in a new release)
  • Bug report
  • Feature request
  • Documentation issue or request
  • Support request

Expected Behaviour

For example, it should show BTC 5.

Current Behaviour

For example, it currently shows 5 BTC.

Possible Solution

Simply change the order of the currency codes.

Steps to Reproduce (for bugs)

  1. Go to any page that shows a currency value, such as the Wallet Info page, signing page, etc.
  2. Notice that currency values are shown with the amount first.

Environment

  • Where are you running caravan: Everywhere
  • Operating system: Linux
  • Browser and version: Chrome 91.0.4472.114
caravan@0.3.8 /home/varun/unchained-capital/caravan
├── unchained-bitcoin@0.1.6 
└─┬ unchained-wallets@0.1.20 
  └── unchained-bitcoin@0.1.6  deduped

npm: 6.14.4 
node: v10.21.0
Linux 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
getsnoopy added a commit to getsnoopy/caravan that referenced this issue Jul 16, 2021
@getsnoopy
fix(other): fix currency formatting throughout app (unchained-capital…
d0e36f8 
…#228)

Currencies in English should always have symbols and codes precede the
amount, not follow them, so this commit fixes all such instances
throughout the app.
@getsnoopy getsnoopy mentioned this issue Jul 16, 2021
Closed
4 tasks
@waldenraines
Copy link
Contributor

See comments on the PR: #229 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(other): fix currency formatting throughout app (#228) getsnoopy/caravan
2 participants
@getsnoopy @waldenraines