New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch component prop blacklist to a whitelist #39

Closed

tractorcow opened this issue Aug 30, 2017 · 1 comment

Collaborator

tractorcow commented Aug 30, 2017

At the moment we have:

const filteredProps = Object.assign({}, this.props);
        delete filteredProps.onSelection;
        delete filteredProps.fixedPosition;
        delete filteredProps.selectOnMouseMove;
        delete filteredProps.component;
        delete filteredProps.tolerance;
        delete filteredProps.preventDefault;

However we end up with errors still.

I suggest to change this to a filtered whitelist of properties that can be safely passed to any component.

clarkepaul mentioned this issue

Create campaign from pages/assets section silverstripe/silverstripe-admin#161

Closed

15 tasks

Collaborator Author

tractorcow commented Aug 31, 2017

Fixed with 0824bfa

tractorcow closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment