Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compress option? #27

Closed
tomByrer opened this issue Dec 30, 2013 · 6 comments
Closed

Remove compress option? #27

tomByrer opened this issue Dec 30, 2013 · 6 comments

Comments

@tomByrer
Copy link

UnCSS removed the compress option (it is all @sindresorhus fault ;). I do see you are using cssmin. It is a good compressor, though I believe many devs have their own favorite minifier.

I can go either way, though I lean towards no minifer. But I wonder if it is more accurate/faster to lightly (non-aggressive) minify CSS first then reduces... hmmm...
I'm just opening this issue up for discussion.

@addyosmani
Copy link
Member

I'd be happy to remove the compress option from this task too. Right now I'm firefighting some multi-file handling issues with this task and uncss (since the move to Phantom) but if you'd like to file a PR I'd be happy to merge :)

@tomByrer
Copy link
Author

if you'd like to file a PR

Thanks! I looked at the source before, but was confused with a few things:

cheers

@sedovsek
Copy link
Contributor

Hey,

I made a pull request: #28
Please review.

Keep up with good work!

@tomByrer
Copy link
Author

Remember the README :)
When I did the Gulp task, I wound up opening every file to see where there was 'compress'.

@sedovsek
Copy link
Contributor

@tomByrer: Ouch, you're right. I was being sloppy. Fixed it, thanks!

@tomByrer
Copy link
Author

Welcome. I did the same thing; submitting after changing only 1 file. Then I remembered there was more than one file in the repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants