Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings popups should close when the user clicks away #24

Closed
PhotoNomad0 opened this issue Jan 20, 2021 · 3 comments
Closed

Settings popups should close when the user clicks away #24

PhotoNomad0 opened this issue Jan 20, 2021 · 3 comments

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Jan 20, 2021

When the user opens card settings the settings don't seem to be attached to the three dot icon - they tend to show up in center of screen. Settings popups should be closed when the user clicks outside of the popup.

DoD: A settings card, invoked from the 3 dot menu, will close when the user clicks outside of the settings card.


Also they are modal which means you can't interact with rest of screen. So we need to do one of

  • dim the rest of the screen to indicate you can't make changes until popup is dismissed
  • have the popup close whenever you click off
  • or both of the above.
@birchamp birchamp changed the title UI problems with card settings Settings popups should close when the user clicks away Jan 21, 2021
@birchamp birchamp added the Priority/Medium Medium Priority issue label Jan 21, 2021
@birchamp
Copy link

@PhotoNomad0 since the settings popup can change how the content is shown in the cards, I don't want to dim. So we will have the popup close when you click off of it. I've changed the issue to reflect that.

@mannycolon mannycolon self-assigned this Feb 23, 2021
@cckozie
Copy link

cckozie commented Mar 29, 2021

Settings popups close when the user clicks away in v0.2.0 build cbad9c9

@elsylambert
Copy link

Works as expected in v0.9.0 build ab13659.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants