F/docker absent #510
Merged
F/docker absent #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 29, 2016 14:36
Changed types: __docker __docker_compose
- Added state parameter for both types in the man.rst - Changed --state absent behavior of __docker_compose -- only remove docker-compose binary not whole docker
dominiqueroux
requested review from
asteven and
darko-poljak
and removed request for
asteven
added 2 commits
December 31, 2016 11:03
darko-poljak
reviewed
Jan 2, 2017
| elif [ ${state} = "absent" ]; then | ||
| __file /usr/local/bin/docker-compose --state absent | ||
| else | ||
| echo "Unknown state: $state_should" >&2 |
There was a problem hiding this comment.
@GreenDeath I think state_should is a typo, it should be state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.