Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow triangular mesh boundary calculation for large meshes #413

Closed
madsendennis opened this issue Dec 26, 2023 · 1 comment
Closed

Slow triangular mesh boundary calculation for large meshes #413

madsendennis opened this issue Dec 26, 2023 · 1 comment

Comments

@madsendennis
Copy link
Collaborator

For large meshes (+100K vertices), the current calculation TriangularMeshBoundaryPredicates is slow.
E.g. a 400K vertice mesh can end up taking +30 seconds.

From debugging, it seems that the slow computation is from a continuous update of a CSCMatrix[Boolean]:

    triangles.foreach { triangle =>
      edgesOfATriangle.foreach { edge =>
        val v1 = triangle.pointIds(edge._1).id
        val v2 = triangle.pointIds(edge._2).id
        edgeOnBorderTmp(v1, v2) = !edgeOnBorderTmp(v1, v2)
        edgeOnBorderTmp(v2, v1) = !edgeOnBorderTmp(v2, v1)
      }
    }
@marcelluethi
Copy link
Contributor

This issue has been resolve (PR #414 ) and published as v0.92.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants