Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavBar responsive breakpoints are hardcoded #27

Open
merlos opened this issue Dec 11, 2018 · 1 comment
Open

NavBar responsive breakpoints are hardcoded #27

merlos opened this issue Dec 11, 2018 · 1 comment
Assignees
Labels
bug Something isn't working medium priority Issue has medium priority
Milestone

Comments

@merlos
Copy link
Member

merlos commented Dec 11, 2018

# Example
@media only screen and (max-width: 767.98px) {

Use instead the mixins defined in:
https://getbootstrap.com/docs/4.1/layout/overview/#responsive-breakpoints

For instance:
@include media-breakpoint-down(xs) { ... }
@include media-breakpoint-down(sm) { ... }
@include media-breakpoint-down(md) { ... }
@include media-breakpoint-down(lg) { ... }
@merlos merlos added low priority Issue has low priority medium priority Issue has medium priority bug Something isn't working and removed low priority Issue has low priority labels Dec 11, 2018
@merlos merlos closed this as completed Dec 18, 2018
@merlos
Copy link
Member Author

merlos commented Jan 8, 2019

Reopened. At least _navbar.scss still has hardcoded breakpoints.

https://github.com/unicef/design-system/blob/master/scss/_navbar.scss

Do review all scss to double check there are no more hardcoded breakpoints.

@merlos merlos reopened this Jan 8, 2019
@merlos merlos added this to the 0.1.0 milestone Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority Issue has medium priority
Projects
None yet
Development

No branches or pull requests

2 participants