CLDR-14032 More space adjustments in DAIP; add test. Run it on en.xml, adjust tests #2001
Conversation
| "{0} g", "{0} g"), // \u00A0 | ||
| new PathSpaceAdjustData("en", | ||
| "//ldml/units/unitLength[@type=\"short\"]unit[@type=\"mass-gram\"]/unitPattern[@count=\"other\"]", | ||
| "g {0}", "g {0}"), // \u00A0 |
There was a problem hiding this comment.
the comments on lines 529 and 532 refer to \u00A0, which, however, doesn't seem to occur in the data on those lines
There was a problem hiding this comment.
sorry, never mind, they do have \u00A0 but somehow it was changed to \u0020 when copy-pasting from browser
There was a problem hiding this comment.
the comments on lines 529 and 532 of TestDisplayAndInputProcessor.java refer to \u00A0, which, however, doesn't seem to occur in the data on those lines
it might be more robust if the \u escapes were in the strings themselves rather than in comments -- anyway, here the comments don't seem to match the data
| "{0} g", "{0} g"), // \u00A0 | ||
| new PathSpaceAdjustData("en", | ||
| "//ldml/units/unitLength[@type=\"short\"]unit[@type=\"mass-gram\"]/unitPattern[@count=\"other\"]", | ||
| "g {0}", "g {0}"), // \u00A0 |
There was a problem hiding this comment.
sorry, never mind, they do have \u00A0 but somehow it was changed to \u0020 when copy-pasting from browser
| @@ -834,13 +834,13 @@ public void TestDayPeriods() { | |||
| checkDayPeriod("pl", "format", "morning1", "〖06:00 – 10:00⁻〗〖❬8:00 ❭rano〗"); | |||
| checkDayPeriod("pl", "stand-alone", "morning1", "〖06:00 – 10:00⁻〗"); | |||
|
|
|||
| checkDayPeriod("en", "format", "night1", "〖00:00 – 06:00⁻; 21:00 – 24:00⁻〗〖❬3:00 ❭at night〗"); | |||
| checkDayPeriod("en", "format", "night1", "〖00:00 – 06:00⁻; 21:00 – 24:00⁻〗〖❬3:00 ❭at night〗"); | |||
There was a problem hiding this comment.
if these are nbsp may be better to escape it in the java source for clarity. That might be a good sweeping change though.
There was a problem hiding this comment.
Yes, filed a separate ticket for that: CLDR-15636
|
I will file a separate ticket to update data files per CLDRModify before general submission. Should probably add to BRS too. |
| checkDayPeriod("en", "format", "am", "〖00:00 – 12:00⁻〗〖❬6:00 ❭AM〗"); | ||
| checkDayPeriod("en", "format", "pm", "〖12:00 – 24:00⁻〗〖❬6:00 ❭PM〗"); | ||
| checkDayPeriod("en", "format", "noon", "〖12:00〗〖❬12:00 ❭noon〗"); | ||
| checkDayPeriod("en", "format", "midnight", "〖00:00〗〖❬12:00 ❭midnight〗"); |
There was a problem hiding this comment.
I think it is probably a mistake to use a NBSP (or NNBSP) between the time (13:00) and an unabbreviated day period. The am/pm are fine, because they are short. But forcing a string like "12:00 midnight" to break as a unit could leave lines unnecessarily ragged.
However, I think that can be discussed and corrected afterwards if necessary.
There was a problem hiding this comment.
@macchiati I did not do anything to the spacing in the patterns that have B (for day periods). I think the issue here is just that the ExampleGenerator code is using time patterns with 'a' to generate examples for dayPeriods. That seems like an ExampleGenerator problem.
There was a problem hiding this comment.
Oh, actually I think it might be in the DateTimePatternGenerator code which, if given a skeleton with 'B', will adjust a time pattern that has 'a' by substituting in the 'B'. Hmm, need to think about how to address that.
There was a problem hiding this comment.
Could fix that in DTPG code, it can remove all NBSP in patterns that end up using B.
There was a problem hiding this comment.
Actually I do not think this is a necessarily problem in DTPG. We have separate availableFormats and intervalFormats for Bh, Bhm and Bhms - and this PR did not change those - so if Example Generator is correctly using DTPG and DIF it should not have gotten the NNBSP above. It may be an ExampleGenerator problem after all. I will investigate.
There was a problem hiding this comment.
Problem is in ICUServiceBuilder.formatDayPeriod, filed https://unicode-org.atlassian.net/browse/CLDR-15645 to fix.
|
Or replace
…On Thu, May 12, 2022 at 9:51 AM Peter Edberg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java
<#2001 (comment)>:
> checkDayPeriod("en", "stand-alone", "night1", "〖00:00 – 06:00⁻; 21:00 – 24:00⁻〗");
- checkDayPeriod("en", "format", "noon", "〖12:00〗〖❬12:00 ❭noon〗");
- checkDayPeriod("en", "format", "midnight", "〖00:00〗〖❬12:00 ❭midnight〗");
- checkDayPeriod("en", "format", "am", "〖00:00 – 12:00⁻〗〖❬6:00 ❭AM〗");
- checkDayPeriod("en", "format", "pm", "〖12:00 – 24:00⁻〗〖❬6:00 ❭PM〗");
+ checkDayPeriod("en", "format", "noon", "〖12:00〗〖❬12:00 ❭noon〗");
+ checkDayPeriod("en", "format", "midnight", "〖00:00〗〖❬12:00 ❭midnight〗");
Could fix that in DTPG code, it can remove all NBSP in patterns that end
up using B.
—
Reply to this email directly, view it on GitHub
<#2001 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBVDNTBDSZ7JPRWXCTVJUZJZANCNFSM5VXNAWSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, that is actually what I meant, sorry. |
|
NP. that's what I figured 🙂
…On Thu, May 12, 2022 at 10:22 AM Peter Edberg ***@***.***> wrote:
Or replace
… <#m_5118431723433578281_>
Yeah, that is actually what I meant, sorry.
—
Reply to this email directly, view it on GitHub
<#2001 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBVGZRXOIDNYOYN6YTVJU45TANCNFSM5VXNAWSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
CLDR-14032
Enhanced DAIP to make the space adjustments per the ticket and associated proposal as discussed in TC:
Added a unit test for these changes.
Then ran CLDRModify -fp on en.xml to show the result of these changes (that also reordered some data items not related to the DAIP changes here). The resulting spacing changes required adjusting the expected results of some unit tests.
I plan to run CLDRModify on the other locales as a separate PR before start of regular submission, either under the ticket for this or another ticket.