Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-21480 Update ICU4C release instructions. Omit 'subversion' #20

Merged
merged 12 commits into from
Mar 22, 2021

Conversation

sven-oly
Copy link
Contributor

@sven-oly sven-oly commented Mar 19, 2021

This fixes formatting and clarifies some instructions.

Removing references to 'subversion' simplifies this and may avoid errors.

This fixes formatting and clarifies some instructions.
@sven-oly sven-oly requested review from roubert and srl295 March 19, 2021 01:08
Subversion is no longer used in this process.
@sven-oly sven-oly changed the title ICU-21480 Update instructions for ICU4C release ICU-21480 Update ICU4C release instructions. Omit 'subversion' Mar 19, 2021
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@markusicu markusicu requested a review from jefgen March 19, 2021 01:42
Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the instructions. :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with the other review comments. And thanks!

sven-oly and others added 4 commits March 19, 2021 10:23
Co-authored-by: Markus Scherer <markus.icu@gmail.com>
Co-authored-by: Steven R. Loomis <srl295@gmail.com>
Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com>
Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few (very) minor nits.
Thanks again for updating this!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sven-oly and others added 4 commits March 19, 2021 17:57
Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com>
Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com>
Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Markus Scherer <markus.icu@gmail.com>
@sven-oly sven-oly merged commit 454fa58 into unicode-org:master Mar 22, 2021
@sven-oly sven-oly deleted the master branch March 24, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants