Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-21480 Update ICU4C release instructions. Omit 'subversion' #20

Merged
merged 12 commits into from
Mar 22, 2021
46 changes: 28 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,37 +18,47 @@ DOCKER_COMPOSE=docker-compose -f local-docker-compose.yml

- install [Docker](http://docker.io)
- bring in ICU source

cd src
git clone --branch master --depth 1 https://github.com/unicode-org/icu.git
cd icu
git lfs fetch
git lfs checkout
cd ../..

````
sven-oly marked this conversation as resolved.
Show resolved Hide resolved
sven-oly marked this conversation as resolved.
Show resolved Hide resolved
cd src
git clone --branch master --depth 1 https://github.com/unicode-org/icu.git
cd icu
git lfs fetch
git lfs checkout
cd ../..
````
- run tests

````
make check-all

````
- build binaries
````
make dist
````
- sort into dist/icu4c-*/*
sven-oly marked this conversation as resolved.
Show resolved Hide resolved

make dist
# sort into dist/icu4c-66.1/*
The files should include the version label such as "69rc" for the release candidate of ICU version 69. The general availability for that woud be "69.1".
sven-oly marked this conversation as resolved.
Show resolved Hide resolved
sven-oly marked this conversation as resolved.
Show resolved Hide resolved
````
./sort-out-dist.sh
ls -l dist/icu4c-*

````
- optional: symlink `src/` to `/src` on your system

this will make error messages work

This will make error messages work
sven-oly marked this conversation as resolved.
Show resolved Hide resolved
````
sudo ln -sv `pwd`/{src,dist} /
````

- do some command line builds

- Perform some command line builds to verify the release.
```
$ docker-compose run ubuntu bash
# This creates a temporary docker shell with a name such as 'build@671f33b0fe95:~'
sven-oly marked this conversation as resolved.
Show resolved Hide resolved
build@59b67f6c5058:~$ /src/icu/icu4c/source/configure
checking for ICU version numbers...
# This will show the ICU version number of the release just created.

build@59b67f6c5058:~$ make check # To run all ICU4C tests
...
build@59b67f6c5058:~$ exit # To leave the docker shell

```

## Author
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/ubuntu/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN useradd -c "Build user" -d $HOME -m build

# sanity and safety
RUN apt-get -q -y update && apt-get -q -y upgrade
RUN apt-get -q -y install make git subversion python ccache valgrind doxygen zip curl wget rsync
RUN apt-get -q -y install make git python ccache valgrind doxygen zip curl wget rsync
RUN apt-get -q -y install g++
RUN apt-get -q -y install git-lfs
RUN mkdir /src /dist
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/ubuntuclang/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ RUN useradd -c "Build user" -d $HOME -m build

# sanity and safety
RUN apt-get -q -y update && apt-get -q -y upgrade
RUN apt-get -q -y install make git subversion python ccache valgrind doxygen zip curl wget
RUN apt-get -q -y install make git python ccache valgrind doxygen zip curl wget
RUN apt-get -q -y install clang
RUN mkdir /src /dist
VOLUME /src
Expand Down