ICU-21109 minimum grouping digits in DecimalFormat #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
force-pushed
the
21109-minimum-grouping
branch
from
2b334aa
to
843aeb1
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
sffc
requested changes
May 27, 2020
sffc
requested changes
Jun 2, 2020
| } | ||
|
|
||
| if (this.grouping1 != -2 && this.grouping2 != -4) { | ||
| return getInstance(this.grouping1, this.grouping2, minGrouping); |
There was a problem hiding this comment.
Return this if minGrouping == this.minGrouping
sffc
requested changes
Jun 10, 2020
| * | ||
| * @see #setMinimumGroupingDigits | ||
| * @see #MINIMUM_GROUPING_DIGITS_MIN2 | ||
| * @draft ICU 68 |
There was a problem hiding this comment.
Please put these in the @category, and add the provisional tag.
sffc
reviewed
Jun 11, 2020
Comment on lines
1998
to
2007
| * Setting the value to 1 to turn off minimum grouping digits. | ||
| * Setting the value to MINIMUM_GROUPING_DIGITS_AUTO to display grouping using the default | ||
| * strategy for all locales. | ||
| * Setting the value to MINIMUM_GROUPING_DIGITS_MIN2 to display grouping using locale defaults, | ||
| * except do not show grouping on values smaller than 10000 (such that there is a minimum of | ||
| * two digits before the first separator). | ||
| * |
There was a problem hiding this comment.
Suggested change
| * Setting the value to 1 to turn off minimum grouping digits. | |
| * Setting the value to MINIMUM_GROUPING_DIGITS_AUTO to display grouping using the default | |
| * strategy for all locales. | |
| * Setting the value to MINIMUM_GROUPING_DIGITS_MIN2 to display grouping using locale defaults, | |
| * except do not show grouping on values smaller than 10000 (such that there is a minimum of | |
| * two digits before the first separator). | |
| * | |
| * Set the value to: | |
| * <ul> | |
| * <li>1 to turn off minimum grouping digits.</li> | |
| * <li>MINIMUM_GROUPING_DIGITS_AUTO to display grouping using the default | |
| * strategy for all locales.</li> | |
| * <li>MINIMUM_GROUPING_DIGITS_MIN2 to display grouping using locale defaults, | |
| * except do not show grouping on values smaller than 10000 (such that there is a minimum of | |
| * two digits before the first separator).</li> | |
| * </ul> |
|
PTAL |
|
Ok. Lgtm. Please squash and I'll approve. |
FrankYFTang
force-pushed
the
21109-minimum-grouping
branch
from
08f9a1f
to
dd8aa11
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
sffc
approved these changes
Jun 11, 2020
pull bot
pushed a commit
to Alan-love/chromium
that referenced
this pull request
Jun 13, 2020
Cherry-pick pull/1152to fix minimum group digits Needed to fix Minimum Grouping Digits for Intl.RelativeTimeFormat Add ability to use locale default for minimum grouping digits - patches/grouping_digits.patch - upstream PR: unicode-org/icu#1152 - upbstream bug: https://unicode-org.atlassian.net/browse/ICU-21109 https://chromium.googlesource.com/chromium/deps/icu.git/+log/46f53df..9e7dae8 9e7dae8 Cherry-pick pull/1152to fix minimum group digits e4b8586 Remove *.mk files which no longer exist c981f19 Sort the list in the filter files w/o changes All these three has no dat size impact. Bug: v8:10443 Change-Id: I3b4e32fae2e50c804bc906c5e279f198b35ad752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242745 Reviewed-by: Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777959}
kishiguro
pushed a commit
to kishiguro/icu
that referenced
this pull request
Jun 16, 2020
Needed to fix Minimum Grouping Digits for Intl.RelativeTimeFormat Add ability to use locale default for minimum grouping digits - patches/grouping_digits.patch - upstream PR: unicode-org/icu#1152 - upbstream bug: https://unicode-org.atlassian.net/browse/ICU-21109 Bug: v8:10443 Change-Id: I5f9f627d8be5cca42d842a4bef4661b29efd060f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2242106 Reviewed-by: Jungshik Shin <jshin@chromium.org>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance DecimalFormat::setMinimumGroupingDigits to accept
UNUM_MINIMUM_GROUPING_DIGITS_AUTO and
UNUM_MINIMUM_GROUPING_DIGITS_MIN2 to support locale default
for minimum grouping digits
Checklist