Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-20191 Don't use Win32 API on Cygwin #185

Merged
merged 1 commit into from
Oct 4, 2018
Merged

ICU-20191 Don't use Win32 API on Cygwin #185

merged 1 commit into from
Oct 4, 2018

Conversation

kbrow1i
Copy link
Contributor

@kbrow1i kbrow1i commented Oct 3, 2018 •
edited by jefgen
Loading

This was fixed in earlier commits (see, for example, ICU-12786), but
the problem was reintroduced in commits f8ba68e and fcb82cb.

Checklist

@kbrow1i
ICU-20191 Don't use Win32 API on Cygwin
dc9b80a 
This was fixed in earlier commits (see, for example, ICU-12786), but
the problem was reintroduced in commits f8ba68e and fcb82cb.
@jefgen jefgen self-assigned this Oct 4, 2018
@jefgen jefgen self-requested a review October 4, 2018 21:07
@jefgen
Copy link
Member

jefgen commented Oct 4, 2018

Thank you very kindly for opening a ticket and for the pull-request with the fix!

I will merge this to master, then cherry-pick the fix over to the maint branch for 63, so that the fix is included in the 63.1 release of ICU4C.

jefgen
jefgen approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jefgen jefgen merged commit 7d99ba4 into unicode-org:master Oct 4, 2018
jefgen pushed a commit to jefgen/icu that referenced this pull request Oct 4, 2018
@kbrow1i @jefgen
ICU-20191 Don't use Win32 APIs on Cygwin (unicode-org#185)
490bb28 
This was fixed in earlier commits (see, for example, ICU-12786), but
the problem was reintroduced in commits f8ba68e and fcb82cb.
jefgen pushed a commit to jefgen/icu that referenced this pull request Oct 4, 2018
@kbrow1i @jefgen
ICU-20191 Don't use Win32 APIs on Cygwin (unicode-org#185)
958afc0 
This was fixed in earlier commits (see, for example, ICU-12786), but
the problem was reintroduced in commits f8ba68e and fcb82cb.

(cherry picked from commit 7d99ba4)
jefgen pushed a commit that referenced this pull request Oct 5, 2018
@kbrow1i @jefgen
ICU-20191 Don't use Win32 APIs on Cygwin (#185)
2e6bfeb 
This was fixed in earlier commits (see, for example, ICU-12786), but
the problem was reintroduced in commits f8ba68e and fcb82cb.

(cherry picked from commit 7d99ba4)
@kbrow1i kbrow1i deleted the cygwin branch October 16, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefgen jefgen jefgen approved these changes

Assignees

@jefgen jefgen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrow1i @jefgen