icu4c: preserve configure arguments #2290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to avoid word splitting on the configure arguments during substitution. A problem was exposed by using CC="ccache mips-openwrt-linux-musl-gcc" (that is, cross-compiling for MIPS OpenWrt with ccache enabled), it failed to build without this change.
|
|
|
@richgillam could you please take a look, and if it looks ok, create a Jira ticket and ask @paulfertser to amend their commit appropriately? |
srl295
approved these changes
Feb 6, 2023
|
still need a ticket and an amended commit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please feel free to consider this a bug report and fix it yourself if you feel like. I'm just trying to keep OpenWrt downstream patches to the minimum, so sending it here for your consideration, I'm not sure I'll be able to properly create a corresponding Jira issue etc.
We want to avoid word splitting on the configure arguments during substitution.
A problem was exposed by using CC="ccache mips-openwrt-linux-musl-gcc" (that is, cross-compiling for MIPS OpenWrt with ccache enabled), it failed to build without this change.
Checklist