Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22526 Allow GMT-23:59 time zone #2646

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Oct 2, 2023

ECMA402 now allow offset timezone from -23:59 to 23:59. We need to lower the minimum ZONE_OFFSET value to -23:59

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22526
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang
Copy link
Contributor Author

I have problem to build/test java in my desktop now. So I will work on a separate Java PR for that once I resolve that.

@FrankYFTang
Copy link
Contributor Author

This fix is needed for JS engine to implmenent tc39/ecma402#788 @sffc @anba

ECMA402 now allow offset timezone from -23:59 to 23:59.
We need to lower the minimum ZONE_OFFSET value to -23:59
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/main/core/src/main/java/com/ibm/icu/util/Calendar.java is now changed in the branch
  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/timezone/TimeZoneTest.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang merged commit d82ad99 into unicode-org:main Oct 4, 2023
99 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22526-tz24 branch October 4, 2023 21:43
gnoliyil pushed a commit to gnoliyil/fuchsia that referenced this pull request Jan 27, 2024
…e GMT-16:00 ... GMT-23:59

This is needed to support ECMA402 PR 788
Upstream bug https://unicode-org.atlassian.net/browse/ICU-22526
Upstream PR unicode-org/icu#2646

Original-Bug: v8:14363
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/4917750
Original-Revision: 995db880cff28a8b5d3a9978acd1b7cab9885edd
GitOrigin-RevId: 9c6217daa9fce6a786534e59b6c2d943f0ce8685
Roller-URL: https://ci.chromium.org/b/8767951069258500337
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I98311ecc7fb3a401934e5a3d01f4fe400b0c0b40
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/928457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants