ICU-20410 Fix grandfathered tag w/ extensions #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
reviewed
Feb 13, 2019
macchiati
previously approved these changes
Feb 14, 2019
FrankYFTang
changed the title
FrankYFTang
force-pushed
the
ICU-20410
branch
from
569f898
to
ee51b6f
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@ macchiati I just made it a single commit. the "git push --force" somehow "dismissed macchiati’s stale review " . could you approve it again. Thanks |
macchiati
previously approved these changes
Feb 14, 2019
markusicu
reviewed
Feb 15, 2019
FrankYFTang
force-pushed
the
ICU-20410
branch
from
eb61a06
to
f857d8c
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@markusicu PTAL |
markusicu
reviewed
Feb 15, 2019
markusicu
requested changes
Feb 15, 2019
| @@ -112,7 +112,7 @@ void LocaleBuilderTest::TestLocaleBuilder() { | |||
| {"B", "fr-FR-1606nict-u-ca-gregory-x-test", "T", | |||
| "fr-FR-1606nict-u-ca-gregory-x-test", | |||
| "fr_FR_1606NICT@calendar=gregorian;x=test"}, | |||
| {"B", "ab-cde-fghij", "T", "cde-fghij", "cde__FGHIJ"}, | |||
| {"B", "cde-fghij", "T", "cde-fghij", "cde__FGHIJ"}, | |||
There was a problem hiding this comment.
Can you revert this change, too?
There was a problem hiding this comment.
In LocaleBuilder, "ab-cde-fghij" is not a valid tag and will fail as illegal argument.
FrankYFTang
force-pushed
the
ICU-20410
branch
from
a36ac8f
to
a3a29ce
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist