Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu_provider_blob contains code that will be rejected by a future version of Rust #4910

Closed
sffc opened this issue May 16, 2024 · 1 comment · Fixed by #4911
Closed

icu_provider_blob contains code that will be rejected by a future version of Rust #4910

sffc opened this issue May 16, 2024 · 1 comment · Fixed by #4911
Assignees
Labels
T-bug Type: Bad behavior, security, privacy

Comments

@sffc
Copy link
Member

sffc commented May 16, 2024

I landed this code in #4887; I had intended to discuss it during the review, but better late than never. I would appreciate if someone else with a high degree of Rust fluency (likely @Manishearth) could see if there's a way to make this work if the #![allow(semicolon_in_expressions_from_macros)] in auxkey_bench.rs is removed.

Reduced example:

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=75617c4dc910f1e7a1f044dbee8e6c9c

@sffc sffc added the T-bug Type: Bad behavior, security, privacy label May 16, 2024
@sffc sffc added this to the 1.5 Blocking ⟨P1⟩ milestone May 16, 2024
@sffc sffc assigned sffc and unassigned Manishearth May 16, 2024
@sffc
Copy link
Member Author

sffc commented May 16, 2024

Fix in #4911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: Bad behavior, security, privacy
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants