Fix bug in segmenter involving short strings of complex scripts #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
aethanyc
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Thank you for fixing this bug! LGTM.
@makotokato should also take a look in case I missed anything.
Nit: We should probably rename complex_word.rs to complex_script.rs since it contains tests for line segmenter now.
|
I will merge in an effort to push 1.2.1 sooner rather than later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that short strings of complex script (more precisely, those with no interior breakpoints) would cause the segmenter to runaway to the end of the string.
I also added an assertion that will fail if this happens again.