Fallback-aware datagen #3487
Merged
Fallback-aware datagen #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested changes
Jun 6, 2023
robertbastian
force-pushed
the
fallback
branch
6 times, most recently
from
3debcf6
to
b800f38
Compare
sffc
reviewed
Jun 7, 2023
robertbastian
force-pushed
the
fallback
branch
3 times, most recently
from
f4c924c
to
79392e4
Compare
robertbastian
requested review from
pdogr,
snktd,
eggrobin,
nordzilla,
aethanyc,
makotokato,
zbraniecki,
hsivonen and
echeran
as code owners
|
The batteries included discussion is isolated in |
|
Removed the |
robertbastian
commented
Jun 20, 2023
| @@ -53,7 +53,7 @@ impl core::fmt::Debug for ExportBox { | |||
| impl<M> UpcastDataPayload<M> for ExportMarker | |||
| where | |||
| M: DataMarker, | |||
| M::Yokeable: Sync, | |||
| M::Yokeable: Sync + Send, | |||
There was a problem hiding this comment.
This is technically breaking, but I think it's almost impossible to have !Send data structs, as they'd have to contain raw pointers or Rc. If we don't want this we can remove locale-level parallelism and generate all locales for each key on the same thread.
There was a problem hiding this comment.
I lean toward shipping this and rolling back if anyone has problems
sffc
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2683
Needed for builtin data.