Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batteries-included baked provider #3549

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jun 20, 2023

Blocked on #3487

Part of #3487

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably spend more time organizing the baked_exporter code, but this is also on par for syn code anyway :/

Actual changes look good. Would be kinda cool if we could speed up the repeated binary search by using the failed binary search index as a quick check first. It's a bit complicated to get right, though, so not worth doing here.

(also: so glad that the baked code is formatted again; this was so much easier to review)

@robertbastian robertbastian merged commit 7f10b15 into unicode-org:main Jun 22, 2023
23 checks passed
@robertbastian robertbastian deleted the batteries branch June 22, 2023 11:36
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns about the batteries-included bake provider are still the same as they were on the other PR.

Given that this PR is merged, let's incorporate this into the summit discussions on the rest of the fallbacking provider infrastructure

@robertbastian
Copy link
Member Author

Note that we did agree on this:

The three runtime providers we support (blob, fs, and unstable) should all add the correct type of fallbacking on their own. It should be driven by metadata in the blob/fs or in the generated code for databake. Could include no_fallback constructors on those three types.

#2683 (comment)

@sffc
Copy link
Member

sffc commented Jun 22, 2023

Note that we did agree on this:

The three runtime providers we support (blob, fs, and unstable) should all add the correct type of fallbacking on their own. It should be driven by metadata in the blob/fs or in the generated code for databake. Could include no_fallback constructors on those three types.

#2683 (comment)

Huh. I wish that discussion included more notes about how we arrived at that conclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants