Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collator supported_locales #4169

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix collator supported_locales #4169

merged 1 commit into from
Oct 17, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Oct 17, 2023 •
edited
Loading

This is the only supported_locales method that inspects the singleton key. It should not do that and instead just return the locales that are supported in the source.

#4168

@robertbastian robertbastian merged commit 697a34f into unicode-org:main Oct 17, 2023
28 checks passed
@robertbastian robertbastian deleted the coll branch October 17, 2023 07:40
sffc
sffc reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @Manishearth