Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more collator tests #4633

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Added more collator tests #4633

merged 2 commits into from
Mar 4, 2024

Conversation

ashu26jha
Copy link
Contributor

@ashu26jha ashu26jha commented Feb 27, 2024 •
edited
Loading

Added collator test for:

  1. vi
  2. de-AT-u-co-phonebk
  3. de-DE-u-co-phonebk

Motivation:

To address part of #4167, also completing one of the todo in tests.rs

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sffc
sffc approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that test_vi fails when the vi-specific data is removed from the collator/dia@1 key. Thank you!

@sffc sffc merged commit 7428f22 into unicode-org:main Mar 4, 2024
30 checks passed
@ashu26jha ashu26jha mentioned this pull request Mar 4, 2024
Closed
@ashu26jha
Copy link
Contributor Author

Thanks!

@ashu26jha ashu26jha deleted the collator_tests branch March 4, 2024 17:29
@ashu26jha ashu26jha mentioned this pull request Apr 2, 2024
Merged
robertbastian pushed a commit that referenced this pull request Aug 13, 2024
@ashu26jha
Add more collator tests (#4767)
8be0aec 
Fixes #4167. Extension of #4633 

Added test for `Tibetan` & `Bosnian`. 

Checks for change in order for `Japanese`. 

I couldn't find more language pair for which collator ordering changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@hsivonen hsivonen Awaiting requested review from hsivonen hsivonen is a code owner

@echeran echeran Awaiting requested review from echeran echeran is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashu26jha @CLAassistant @sffc