unicorn_arm: add reg_read/write operations for FPSCR and FPSID #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are adding support for VFP control registers, I kindly ask you to support all of them (FPSCR, FPSID,or FPEXC), not just only one. |
scribam
changed the title
|
FPSID added, FPEXC was already done. |
|
can you add few sample code using these registers into sample_arm.c? |
|
I would also expect you to add a new test for these registers in tests/unit/test_arm.c. |
|
Rebased to fix conflicts. I don't plan to add tests so feel free to take over or to close this PR. |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.