aarch64: Add FPCR and FPSR registers #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: merry <git@mary.rs>
wtdcode
reviewed
Oct 14, 2022
Co-authored-by: merry <git@mary.rs>
|
Should be better now |
|
Thanks and welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR adds support for the FPCR and FPSR registers for aarch64.
I'm still new to unicorn and trying to learn how it works, so I hope I didn't miss anything. These changes are based on an old commit by @merryhime from 2018 and I just adjusted it to work with the current code base.
Currently projects like Ryujinx need to patch unicorn to support them for their tests, but I think integrating them into unicorn makes a lot more sense, than maintaining a patch. Especially when it's this small and might also benefit some other projects.