Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Update NcISO to specify gmd:protocol for service endpoints #75

Closed
rsignell-usgs opened this issue Sep 5, 2014 · 8 comments
Closed

Update NcISO to specify gmd:protocol for service endpoints #75

rsignell-usgs opened this issue Sep 5, 2014 · 8 comments

Comments

@rsignell-usgs
Copy link
Contributor

As discussed in the pycsw issue here: geopython/pycsw#269, catalog services that rely on OWSlib like pycsw expect to have gmd:protocol specified in order to populate the scheme in the references that get returned from a CSW request. Without this, SOS, WMS, OpeNDAP endpoints, etc always come back with scheme of None.

Should just need to modify the UnidataDD2MI.xsl file:
https://github.com/Unidata/thredds/blob/f902e5a3573583a9b87f1d3c7d2ff27a121289fe/tds/src/main/webapp/WEB-INF/classes/resources/xsl/nciso/UnidataDD2MI.xsl

@pacioos, I know you've addressed this -- can you please submit a PR to fix this?
I raised the same issue at ethanrd/threddsIso#2 because I wasn't sure what the development path is on ncISO, and maybe we need to fix in both places?

@rsignell-usgs
Copy link
Contributor Author

@tomkralidis, for populating gmd:protocol we should use the identifier listed in https://github.com/OSGeo/Cat-Interop/blob/master/LinkPropertyLookupTable2.csv, correct?

@tomkralidis
Copy link

👍

@pacioos
Copy link

pacioos commented Sep 6, 2014

OK, I've submitted the PR here: Unidata/threddsIso#1
Cheers,
John

On Fri, Sep 5, 2014 at 1:14 AM, Rich Signell notifications@github.com
wrote:

As discussed in the pycsw issue here: geopython/pycsw#269
geopython/pycsw#269, catalog services that
rely on OWSlib like pycsw expect to have gmd:protocol specified in order to
populate the scheme in the references that get returned from a CSW request.
Without this, SOS, WMS, OpeNDAP endpoints, etc always come back with scheme
of None.

Should just need to modify the UnidataDD2MI.xsl file:

https://github.com/Unidata/thredds/blob/f902e5a3573583a9b87f1d3c7d2ff27a121289fe/tds/src/main/webapp/WEB-INF/classes/resources/xsl/nciso/UnidataDD2MI.xsl

@pacioos https://github.com/pacioos, I know you've addressed this --
can you please submit a PR to fix this?
I raised the same issue at ethanrd/threddsIso#2
ethanrd/threddsIso#2 because I wasn't sure
what the development path is on ncISO, and maybe we need to fix in both
places?


Reply to this email directly or view it on GitHub
#75.

@rsignell-usgs
Copy link
Contributor Author

I installed the Version 4.5.4-SNAPSHOT - 20141008.1804 snapshot of the THREDDS Data Server, and was disappointed to find out this PR to ncISO merged on Sep 8
Unidata/threddsIso@52f1bf8
has not yet been implemented in the TDS.

Do we need to submit a PR to this repo as well? I'm confused about the development chain here...

We just want to update the UnidataDD2MI.xsl file from this one:
https://github.com/Unidata/thredds/blob/4.5.4/tds/src/main/webapp/WEB-INF/classes/resources/xsl/nciso/UnidataDD2MI.xsl

to this one:
https://github.com/Unidata/threddsIso/blob/master/src/main/resources/xsl/nciso/UnidataDD2MI.xsl

@ethanrd
Copy link
Member

ethanrd commented Nov 7, 2014

Hi Rich,

Yes, sorry about that, I dropped the ball on that one.

We need to build a new version of threddsIso.jar so we can fold that into
the TDS build. Hopefully, all that requires is a build/deploy in
Unidata/threddsIso and an update of the threddsIso version number in the
TDS pom file.

We'll let you know when that is done.

Ethan

On Thu, Nov 6, 2014 at 6:29 AM, Rich Signell notifications@github.com
wrote:

I installed the Version 4.5.4-SNAPSHOT - 20141008.1804 snapshot of the
THREDDS Data Server, and was disappointed to find out this PR to ncISO
merged on Sep 8
Unidata/threddsIso@52f1bf8
Unidata/threddsIso@52f1bf8
has not yet been implemented in the TDS.

Do we need to submit a PR to this repo as well? I'm confused about the
development chain here...

We just want to update the UnidataDD2MI.xsl file from this one:

https://github.com/Unidata/thredds/blob/4.5.4/tds/src/main/webapp/WEB-INF/classes/resources/xsl/nciso/UnidataDD2MI.xsl

to this one:

https://github.com/Unidata/threddsIso/blob/master/src/main/resources/xsl/nciso/UnidataDD2MI.xsl


Reply to this email directly or view it on GitHub
#75 (comment).

@rsignell-usgs
Copy link
Contributor Author

@kristiansebastian, yes, you won't have to reapply the xslt after the next release of TDS!

@kevin-obrien
Copy link

Is this xsl update THREDDS version agnostic? Or only to be applied to latest version?

@rsignell-usgs
Copy link
Contributor Author

this xsl is indeed THREDDS version agnostic.
closing this because it was fixed in #114

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants