Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adden instance method Mean to Jax frontend #14172

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Adden instance method Mean to Jax frontend #14172

merged 2 commits into from
Apr 30, 2023

Conversation

RakshitKumar04
Copy link
Contributor

No description provided.

@RakshitKumar04
Copy link
Contributor Author

Close #14170

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Apr 14, 2023
@RakshitKumar04
Copy link
Contributor Author

Hey, @valeriocost the implementation passed 4 out of 5 tests when ran locally. The fifth test is failing may be due to the where argument that has not been initialized and used in the test function but when I do so all 5 tests get failed.

Please guide me on how to declare and initialize the where argument in the test function.

@valeriocost
Copy link
Contributor

Hi @RakshitKumar04, you should probably take a look here https://lets-unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html where we explained how to write frontends tests. Thanks 😄

@RakshitKumar04
Copy link
Contributor Author

Hey, @valeriocost can you please review my PR.

@valeriocost
Copy link
Contributor

@RakshitKumar04 try to rebase with master first because a lot tests are failing and are not related to your PR, thanks 😄

@RakshitKumar04 RakshitKumar04 force-pushed the jax-instMeth-mean branch 2 times, most recently from 2737cb8 to 881a9dc Compare April 24, 2023 14:58
@RakshitKumar04
Copy link
Contributor Author

hey @valeriocost I have rebased it, is it fine now?

@RakshitKumar04 RakshitKumar04 deleted the jax-instMeth-mean branch April 24, 2023 16:45
@RakshitKumar04 RakshitKumar04 restored the jax-instMeth-mean branch April 24, 2023 16:46
@RakshitKumar04 RakshitKumar04 force-pushed the jax-instMeth-mean branch 6 times, most recently from f063f50 to c9a5074 Compare April 25, 2023 18:37
@RakshitKumar04
Copy link
Contributor Author

Hey, @valeriocost Please review my PR.

@RakshitKumar04
Copy link
Contributor Author

Hey @valeriocost please review the PR.

@valeriocost
Copy link
Contributor

LGTM, ready to merge 👍🏼

@valeriocost valeriocost merged commit 37d53fd into ivy-llc:master Apr 30, 2023
@RakshitKumar04 RakshitKumar04 deleted the jax-instMeth-mean branch June 20, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@valeriocost valeriocost

Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RakshitKumar04 @valeriocost @ivy-leaves