Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added conjugate function to Numpy Frontend #14594

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Added conjugate function to Numpy Frontend #14594

merged 3 commits into from
Apr 28, 2023

Conversation

RakshitKumar04
Copy link
Contributor

No description provided.

@RakshitKumar04
Copy link
Contributor Author

Close #14593

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Apr 25, 2023
@RakshitKumar04
Copy link
Contributor Author

Hey, @xoiga123 Please review my PR.

@xoiga123
Copy link
Contributor

Hi, as noted in numpy's docs:

conj is an alias for conjugate

And given that conj is already implemented in the numpy frontend, please change your implementation according to our Duplicate Policy 🤗 You should not repeat the same thing twice.

@RakshitKumar04
Copy link
Contributor Author

Hey @xoiga123 I have re-implemented the conjugate function, Please review it.

@xoiga123
Copy link
Contributor

LGTM! Thank you for contributing to Ivy 🤗

xoiga123
xoiga123 suggested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@xoiga123 xoiga123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold up 🛑 Seems like the test doesn't pass

...t_ivy/test_frontends/test_numpy/test_mathematical_functions/test_handling_complex_numbers.py Show resolved Hide resolved
@xoiga123
Copy link
Contributor

LGTM for real this time! Have a nice weekend! ⭐

@xoiga123 xoiga123 merged commit 1dbb893 into ivy-llc:master Apr 28, 2023
@RakshitKumar04 RakshitKumar04 deleted the conjugateNumpy branch June 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoiga123 xoiga123 xoiga123 approved these changes

Assignees

@xoiga123 xoiga123

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RakshitKumar04 @xoiga123 @ivy-leaves