Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add makefile, makefile.uk #4

Closed
wants to merge 3 commits into from
Closed

add makefile, makefile.uk #4

wants to merge 3 commits into from

Conversation

akouk
Copy link

@akouk akouk commented Mar 31, 2023

Signed-off-by: akouk <kouka.anisa@gmail.com>
@razvand razvand self-requested a review April 16, 2023 09:34
@razvand razvand self-assigned this Apr 16, 2023
@razvand
Copy link
Contributor

razvand commented Apr 16, 2023

@akouk, why are there so many files in the pull request? You included build files as well. Only include Makefile and Makefile.uk.

@razvand
Copy link
Contributor

razvand commented Apr 16, 2023

@akouk, also please improve your commit message. Use full sentences, add a detailed description of the changes.

Also use your full name both as the commit author and for the Signed-off-by message.

akouk added 2 commits May 4, 2023 17:23
Signed-off-by: Anisa Kouka <77749065+akouk@users.noreply.github.com>
@razvand
Copy link
Contributor

razvand commented Sep 30, 2023

Closing this, since it was solved by #5

@razvand razvand closed this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants